Uma Kadam

Results 15 comments of Uma Kadam

#3463 #2450 are the previous issues regarding this .

> Thank you @umak1106 for opening this issue. > > There are 3 main objectives with the type hinting of the library: > * detect errors in the library code...

Regarding the stp() function if i set the arguments as arraylike i get this error Argument 1 to "cross" has incompatible type "Union[_SupportsArray[dtype[Any]], _NestedSequence[_SupportsArray[dtype[Any]]], bool, int, float, complex, str, bytes,...

actually typing module is introduced in numpy from 1.20.0 and the gh-ci.yaml file has numpy = 1.19.0 which is why i think the tests are failing

Errors am facing : MDAnalysis/lib/pkdtree.py:141: error: Incompatible types in assignment (expression has type "Optional[float]", variable has type "None") MDAnalysis/lib/pkdtree.py:184: error: Unsupported operand types for > ("float" and "None") MDAnalysis/lib/pkdtree.py:234: error:...

> It looks like you are still using `npt.NDArray` in pkdtree. Yes actually after i faced mypy errors there i didn't push my code

Making those changes in pkdtree raises errors like unresolved reference to self

> > Making those changes in pkdtree raises errors like unresolved reference to self > > Can you paste the full error message please? It is difficult to figure out...

> Congratulations on that PR being merged! Thanks