Ulrik Falklöf

Results 50 comments of Ulrik Falklöf

Distinguishing on OS might cause problems for users in other countries with different default Locale. One alternative could be to get the JVMs decimal separator char for current `Locale.getDefault()`, via...

Thank you @meisterT for reviewing! AFAIK, BEP provides CPU time only for: - The JVM process. and the `--profile` json file contains CPU usage only for: - The JVM Process....

Do you know the reason to the fetch failures / closed connections? Is there high package loss due to package congestion? Or overloaded server? Something else?

> I will need to set aside some time to look through this properly (perhaps tomorrow, but more likely monday). Thanks Mostyn! No problem waiting to monday. > I agree...

> If we're not doing those checks then maybe the AC+CAS hit rate is more interesting? Personally I would be most interested in only AC, regardless of validation/completeness checking, since...

I’m elaborating about use cases with examples: Bazel clients configured to always add flags like: ``` --remote_header=user=$USER --remote_header=host=$HOST --remote_header=os=\`get_os_name.sh\` ``` And bazel clients invoked via CI can in addition add...

I become inspired by https://github.com/buchgr/bazel-remote/issues/355 and will play around with what happens if disk.go would implement an interface like: ``` type CasAcCache interface { Put(kind EntryKind, hash string, size int64,...

> > In disk.go or http.go/grpc*.go? > > If we're not differentiating between http and grpc cache lookups, I think it probably makes sense to do this in disk.go -...

Which cache operations should do the data verification? Put? Get? Contains? **Have you benchmarked how performance is affected?** Especially for HTTP/1.1-without-SSL use cases, where golang’s io.Copy can use linux kernel’s...

Thanks Mostyn, I'm thinking for example allow creating and replacing `cache.Proxy` instances at runtime. And protect the reference to current proxy instance in disk.go with a mutex. And perhaps in...