Victor S.
Victor S.
1. Add ability to throw on warning/notice 2. Maybe add filters for exception logging ## Summary 1. Currently `Notice - Undefined index` does not stop execution but it could lead...
### Description: Resolves #212 ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code with strange input, with strange internal...
### Description: Allows to resolve n+1 queries when deleting all templates in version ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior...
See #523  ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code with strange input, with strange internal state...
### Description: See #523  ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code with strange input, with strange...
### Description: Allows to reduce n+1 queries especially in import ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code...
- [x] https://github.com/matomo-org/tag-manager/pull/520 - [ ] https://github.com/matomo-org/tag-manager/pull/521 - [ ] https://github.com/matomo-org/tag-manager/pull/522 - [ ] `deleteContainer*` (Template) methods every time check template references causing loop in loop but EVERY template will...
## Summary GTM provides whole var for lookup table which allows variables substitution:  Maybe also add this ability to Matomo lookup table:  It could be used to create...
Variables: https://github.com/matomo-org/tag-manager/blob/44d38e81d696509c6c071afcf1d3f3e0a2e223b4/Dao/VariablesDao.php#L29 Triggers: https://github.com/matomo-org/tag-manager/blob/44d38e81d696509c6c071afcf1d3f3e0a2e223b4/Dao/TriggersDao.php#L29 Tags: https://github.com/matomo-org/tag-manager/blob/44d38e81d696509c6c071afcf1d3f3e0a2e223b4/Dao/TagsDao.php#L30 `TINYINT` for **status** should be sufficient It repeats string like `active`/`deleted` but could be about 8 times shorter
Maybe create types ```js /* eslint-disable max-len */ /** * @typedef {int} callbackIndex * * @typedef {object} TagManager.dataLayer * @property {(name: string) => any} get - Retrieve a value from...