Victor S.

Results 21 issues of Victor S.

1. Add ability to throw on warning/notice 2. Maybe add filters for exception logging ## Summary 1. Currently `Notice - Undefined index` does not stop execution but it could lead...

Enhancement

### Description: Resolves #212 ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code with strange input, with strange internal...

Needs Review

### Description: Allows to resolve n+1 queries when deleting all templates in version ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior...

See #523 ![image](https://user-images.githubusercontent.com/32728904/182839317-26905fc0-d24d-4775-8b91-4a8132ed0659.png) ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code with strange input, with strange internal state...

### Description: See #523 ![image](https://user-images.githubusercontent.com/32728904/182841246-3360f8a4-4cbb-4344-ae4d-b3aa8475861c.png) ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code with strange input, with strange...

### Description: Allows to reduce n+1 queries especially in import ### Review * [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done) * [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code...

- [x] https://github.com/matomo-org/tag-manager/pull/520 - [ ] https://github.com/matomo-org/tag-manager/pull/521 - [ ] https://github.com/matomo-org/tag-manager/pull/522 - [ ] `deleteContainer*` (Template) methods every time check template references causing loop in loop but EVERY template will...

## Summary GTM provides whole var for lookup table which allows variables substitution: ![image](https://user-images.githubusercontent.com/32728904/179516939-dc2f079a-fb6e-4d2e-b141-cd2690faf5f5.png) Maybe also add this ability to Matomo lookup table: ![image](https://user-images.githubusercontent.com/32728904/179517110-a7abb1de-c10a-4ae4-b105-beaf88d82af0.png) It could be used to create...

Enhancement

Variables: https://github.com/matomo-org/tag-manager/blob/44d38e81d696509c6c071afcf1d3f3e0a2e223b4/Dao/VariablesDao.php#L29 Triggers: https://github.com/matomo-org/tag-manager/blob/44d38e81d696509c6c071afcf1d3f3e0a2e223b4/Dao/TriggersDao.php#L29 Tags: https://github.com/matomo-org/tag-manager/blob/44d38e81d696509c6c071afcf1d3f3e0a2e223b4/Dao/TagsDao.php#L30 `TINYINT` for **status** should be sufficient It repeats string like `active`/`deleted` but could be about 8 times shorter

Maybe create types ```js /* eslint-disable max-len */ /** * @typedef {int} callbackIndex * * @typedef {object} TagManager.dataLayer * @property {(name: string) => any} get - Retrieve a value from...