Ufuk Celebi
Ufuk Celebi
We now have defaults in place. I'm moving the priority down to P2.
@jkosh44 should have a fix up for this in https://github.com/MaterializeInc/materialize/pull/14092.
@heeringa Updated the original issue description to reflect the open tasks here.
We can probably pick up the remaining testing tasks after the upsert source work has been implemented.
@petrosagg Thank you for the write-up. Would the `SourceReader` changes you have in mind conflict with the ongoing work in BIR or Postgres demuxing? I'm trying to think through whether...
Thanks for your answers, folks! Two take-aways: * Let's do the one-line fix Petros outlined (if there are no technical concerns) * Let's not start anything else before BIR and...
Thank you for debugging this. Let's close this issue after this week's release is out (with 508ed52 reverted).
Thanks for reviews! I'll merge once CI passes. @pH14 I created https://github.com/MaterializeInc/materialize/issues/14918 to track your suggested refactoring.
I've removed the triage label, because it's reserved for bugs (?).
Playing devil's advocate: Is the trade-off between time invested and bugs caught by proptest worth it for us? What does proptest cover that we are not covering via other existing...