klein

klein copied to clipboard

glyph

[pre-commit.ci] pre-commit autoupdate

1

updates: - [github.com/PyCQA/flake8: 4.0.1 → 5.0.4](https://github.com/PyCQA/flake8/compare/4.0.1...5.0.4) - [github.com/asottile/pyupgrade: v2.34.0 → v2.38.2](https://github.com/asottile/pyupgrade/compare/v2.34.0...v2.38.2) - [github.com/asottile/yesqa: v1.3.0 → v1.4.0](https://github.com/asottile/yesqa/compare/v1.3.0...v1.4.0) - [github.com/psf/black: 22.3.0 → 22.8.0](https://github.com/psf/black/compare/22.3.0...22.8.0) - https://github.com/myint/autoflake → https://github.com/PyCQA/autoflake - [github.com/PyCQA/autoflake: v1.4 → v1.6.1](https://github.com/PyCQA/autoflake/compare/v1.4...v1.6.1)

pre-commit-ci[bot]

the bug in question: https://github.com/twisted/twisted/issues/11580 fixes #486 the `--logfile` option is intended to be a *relative* path from the temp dir anyway, so even after this bug is fixed we...

glyph

hyperlink generates invalid URLs via hypothesis which sometimes causes our tests to fail

1

for example: https://github.com/twisted/klein/runs/6682625798?check_suite_focus=true ``` Error: Traceback (most recent call last): File "/home/runner/work/klein/klein/.tox/coverage-py37-tw203/lib/python3.7/site-packages/klein/test/test_request_compat.py", line 99, in test_uri def test_uri(self, url: DecodedURL) -> None: File "/home/runner/work/klein/klein/.tox/coverage-py37-tw203/lib/python3.7/site-packages/hypothesis/core.py", line 1235, in wrapped_test raise the_error_hypothesis_found...

glyph

Fix tox -e coverage-py39-twtrunk

4

Tox / pip fails to install / creates the virtual env for klein using Twisted trunk Here is a build failure - https://github.com/twisted/klein/runs/2306282515#step:6:287 There are 2 issues with pip deps...

adiroiban

Follow-up to #246: that only included ephemeral memory-backed storage, this is the "real" thing. No tests yet though, so not ready to land.

glyph

Add type hints for klein.test.test_app

6

Add type hints for `klein.test.test_app`

wsanchez

whenever someone has a spare moment it would be nice to update to less problematic terminology

glyph

``` [FAIL] Traceback (most recent call last): File "/home/exarkun/VirtualEnvs/scratch/lib/python3.9/site-packages/klein/test/test_form.py", line 763, in test_cookieWithToken self.assertEqual(to.calls, [("hello", 1234)]) File "/home/exarkun/Work/python/twisted/src/twisted/trial/_synctest.py", line 432, in assertEqual super(_Assertions, self).assertEqual(first, second, msg) File "/nix/store/wl02plhc6zf84m6x9984l42wnnnbly5m-python3-3.9.6/lib/python3.9/unittest/case.py", line 831,...

exarkun

Why do client socket resets cause pending Deferred to be cancelled?

4

Imagine you have a route like the following. ``` @app.route("/foo", methods=["POST"]) @inlineCallbacks def doStuff(self, request): yield foo() yield bar() return {"message": "success"} ``` And then a client calls `POST /foo`...

KentShikama