Devin Mullins
Devin Mullins
We should update the golang version in the [Dockerfile.template](https://github.com/GoogleCloudPlatform/click-to-deploy/blob/5c7523aefa0318aadaf3f4b1f809564d335fed85/docker/amppackager/templates/debian10/Dockerfile.template#L18) to match the one we're testing in [PR checks](https://github.com/ampproject/amppackager/blob/main/.github/workflows/prerequisites.yml), and then do another c2d release.
To do so, we need to address the use cases it serves: 1. **It makes it obvious when we're increasing our binary size too much.** We could do this with...
It is confusing for developers that `releases` is the default branch. Also a vector for error: sometimes PRs are sent against `releases` instead. As of Go 1.16 (I think), we...
Some folks are using `cmd/transform` + `gen-signedexchange` offline, rather than running `cmd/amppkg` online. Improve this use case, filling in the gaps of the other things amppkg does with offline alternatives:...
Document in [amppkg.example.toml](https://github.com/ampproject/amppackager/blob/6a1c7afdb77f4fb54a848e49deccdf5fa01ff76f/amppkg.example.toml#L216-L219) that the ACME discovery URL itself may expire and need to be refreshed. (Link to any CA documentation that's available on when it expires.)
When receiving an OCSP response, AMP Packager should validate that its ProducedAt is within the NotBefore/NotAfter of the cert. I think the place to do that is [here](https://github.com/ampproject/amppackager/blob/f36311a1de3c0437debf0f6d1c3a0bf6666c7a0a/packager/certcache/certcache.go#L636-L659). (It looks...
Currently, CertCache has a bunch of fields named foo and renewedFoo, to store info about the old and new certificate (for ACME renewal). Two things: - It's missing renewedOCSP fields,...
When building cmd/amppkg with `-tags dns01` and running, we get the following warning msg on stdout: ``` WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated. A future release of golang/protobuf will delete this...
@jridgewell's http://cl/327496988 (c/o #466) converts hero images from `amp-img` to `amp-img > img` and adds `link rel=preload`. In addition, for SXG, we should convert *all* `amp-img`s on the page to...