Tommy Volk
Tommy Volk
> The sequence num is always increasing but it doesn't guarantee to have the same order as the creation time. Gotcha. Then I think a good plan for now is...
I can give this a shot!
@Roasbeef what sort of filtering approach would be better? Two approaches come to mind for me 1. Adhere to [Google's AIPs](https://google.aip.dev/), which specifiy [how List methods should handle filtering](https://google.aip.dev/132#filtering) through...
Gotcha, that's sort of what I figured. I'll stick with `min_creation_date` and `max_creation_date`. Hoping to have a PR out by tomorrow.
> There exist a spec proposal to add a new address type to the `NodeAnnouncement` message. @Roasbeef can you link the spec you're talking about? All I could find was...
LGTM! I left one comment about a potential cleanup.
I updated the release notes to 0.16.0! Hmmm that's strange, I feel like that test _could_ be related to this change. I'll dig into that a bit and see what...
Circling back to this... I took a look at that test, but I wasn't able to get it to fail using `make unit pkg=htlcswitch`. @carlaKC could you show me how/where...
I can take this one!
> Maybe we could replace the devimint logic for opening channels with this? It would allow us to simplify the devimint code. That makes sense to me! I'll work on...