Turo Lamminen

Fix loading .blend files and some other miscellaneous fixes I found along the way. Most shipped .blend files now load. The only one that doesn't is "BlenderDefault_262.blend" but I'm not...

Refactor idGameEdit

10

Split `idGameEdit` into base class `idGameEditBase` which is in the main binary and `idGameEdit` which is only referenced in the game libraries. This was an attempt to fix UBSAN compilation....

Fails to build with Undefined Behavior Sanitizer (ubsan)

3

Add `CXXFLAGS="-fsanitize=undefined"` before cmake to enable ubsan (with relatively recent Clang or GCC). Build then fails with: ``` CMakeFiles/dhewm3.dir/tools/compilers/dmap/map.cpp.o:(.data+0xd258): undefined reference to `typeinfo for idGameEdit' CMakeFiles/dhewm3.dir/tools/compilers/aas/AASBuild.cpp.o:(.data+0xa1b8): undefined reference to `typeinfo...

s_noSound together with timedemo crashes the game

6

Setting s_noSound 1 doesn't actually disable OpenAL. Sounds are silenced but AL calls still happen. I wanted to disable sound entirely because under Valgrind the game is really slow and...

Race conditions between main thread and SDL async timer thread

1

ThreadSanitizer report: ``` WARNING: ThreadSanitizer: data race (pid=25333) Read of size 4 at 0x000001ddbdf0 by main thread: #0 idSessionLocal::DrawWipeModel() neo/framework/Session.cpp:2220 (dhewm3+0x00000066b8e9) #1 idSessionLocal::Draw() neo/framework/Session.cpp:2454 (dhewm3+0x00000066b8e9) #2 idSessionLocal::UpdateScreen(bool) neo/framework/Session.cpp:2497 (dhewm3+0x0000006742e9) #3...

Automatically check code style as part of CI

1

Code style (formatting etc) should be checked as part of CI build. We need to: 1. Decide on a formatter. `clang-format` is fairly standard. We might have to pick a...

There's a lot of issues with config variable strings. Let's pick an example: https://github.com/chocolate-doom/chocolate-doom/blob/5ccf89a00d7be33b1934d22a9eb8d82a2be153c4/src/i_video.c#L107 `window_position` is assigned a string constant so it should be const. But it can't be because...

From C++ compatibility branch: ``` src/doom/am_map.c:547:34: error: enum conversion in initialization is invalid in C++ [-Werror=c++-compat] static event_t st_notify = { 0, ev_keyup, AM_MSGEXITED, 0 }; ``` https://github.com/chocolate-doom/chocolate-doom/blob/5bf73c4864fedb6b97b27bf302435a1168ba8f4c/src/doom/am_map.c#L545 `ev_keyup` is...

At `I_Quit` time the handlers registered with `I_AtExit` are ran but the handlers themselves are not freed. This caused me grief when doing #1250 since I saw an additional memory...

If application creates its buffers with glBufferStorage and without GL_MAP_READ_BIT, their contents aren't shown in the GUI. I worked around this by [adding the flag in the application when tracing](https://github.com/turol/smaaDemo/commit/203e9918cd4871ce9ec6fe05f13cfc3abc508b94)...