ttoad

Results 20 comments of ttoad

> How about using the logr interface instead of a custom-made logger that will only be used here? While only using the `Error` interface... The level parameter in logr.Info() makes...

> I second the recommendation to use `Logr`. I do not want to see each and every instrumentation creating and maintaining a logging interface. This is something that we should...

I'm not sure I understand it correctly. logr.Logger is a struct.When using the `WithLogger(logr.Logger)` option, the end user needs to implement the `logr.LogSink` interface. When using the `WithLogger(logr.Logger)` option, the...

@dmathieu @Aneurysm9 PTAL. Should I add changelog or use skiplog label?

![image](https://user-images.githubusercontent.com/14021602/167790083-16ee3803-e8db-404d-9760-107141f354d7.png) In code https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/samplers/jaegerremote/sampler_remote.go#L149 , the output of the log is commented out... The log should be output.

> Given the existing metrics Views SDK specification supports the kind of query used in your example, this appears to be a request for dynamic configuration of the SDK for...

支持opentelemetry定义的可观测性数据上报...

@MrAlias I think I addressed all of your concerns. PTAL

> Please restore the dependabot configuration: [#2566 (comment)](https://github.com/open-telemetry/opentelemetry-go-contrib/pull/2566#discussion_r1013026356) Sorry, I forgot to commit it. It has been restored. PTAL

Maybe we can modify the output file like this: ``` type _go_types_Object struct { IValue interface{} } func (W _go_types_Object) Exported() bool { return W.IValue.(types.Object).Exported() } func (W _go_types_Object) Id()...