Timo Lappalainen comments

Results 814 comments of


                                            Timo Lappalainen

Unit problem in ROT (and others?)

Value should be converted to rad/s so it should be RateOfTurn=NMEA0183GetDouble(NMEA0183Msg.Field(0),degToRad/60);

Missing class name for breaktime in NMEA0183Messages.cpp and missing macro in NMEA0183Msgs.h

Thanks. This is now fixed. I had to use specific NMEA0183IsTimeNA since in some environments time_t is int32_t and NMEA0183IsNA would cause redefinition error. I did not found other reliable...

Parsing NMEA messages should be robust against to much fields

Thanks. Added it after increment.

Parsing NMEA messages should be robust against to much fields

You are rigth, but then it should be before line Fields[_FieldCount]=iData+1; // Set start of field On my code that is line 100.

Parsing NMEA messages should be robust against to much fields

OK, now it is updated.

NMEA checksum should accept lowercase

This has been fixed already on last summer, but for some reason I had not pushed it to github. Now it is there wit some other updates I had on...

LatLonToDouble(const char *data, const char sign) return 0 instead NA when given ""

Sorry for delay. I am working with this. I had these fixed on my other code by using NMEA0183GetDouble instead of atof.

MWV True wind != Theoretical wind

Damn. https://gpsd.gitlab.io/gpsd/NMEA.html#_mwv_wind_speed_and_angle says True. It is problematic, since it changes compatibility.

timezone error in tNMEA0183Msg:makeTime(..)

I have to check - it is not that simple. In early days Arduino tim support was, what it was. It is important that any change does not cause incompamtibility...

timezone error in tNMEA0183Msg:makeTime(..)

Arduino environment does not have timezone so that can not be used. I could bring timezone to library by with: ``` int32_t tNMEA0183Msg::GetTimeZone() { tmElements_t tme; SetYear(tme,1970); SetMonth(tme,1); SetDay(tme,2); SetHour(tme,0);...