Noam Meltzer

Results 35 comments of Noam Meltzer

@Oppen I get what you're saying that a consolidated way is for the best. However, since DPDK, XDP & PF_PACKET are so different in semantics, requiring the direct consumer to...

> @tsnoam I see your point, but I think masking implementation details is more or less the point of using libpcap as an abstraction. I'm OK-ish with marking it as...

Also, thanks for the review. I pushed and updated version of the code.

> * I agree. > > * That wasn't a counter argument or a suggestion for you to implement it now. It was just a "look at this cool thing",...

@aouinizied Sorry for the delay in response, I'm happy to see that you've eventually fixed the problem. Anyhow, most of the thanks are to @xpahos who had made the original...

@mcr I've rebased my branch on top of the latest master and made appropriate fixes as of commit 97f59a7d035397c7b4f4889ef5657be811b97e7a

@aouinizied I tried rebasing (and then build), and it passes cleanly. have you encountered problems trying to rebase yourself?

Hi @aouinizied , As the branch can be directly merged to master, i mostly wait for the maintainers to pick it up. Since rebasing will also require me to test...

@mcr Do you have an estimation when this PR will be merged to master? Is there something you expect me to change which I've missed? Anything I can do to...

@mcr I've added the documentation as requested. I hope it is clear enough. If not, I'll be happy to fix as necessary. @infrastation I do consider this change as ready...