Takeo Sawada comments

Results 19 comments of


                                            Takeo Sawada

Support Well Known Types

Hi @pfgallagher, thanks for your PR. This fix is essential for my usecase. Are you still interested in merging?

Missing exports: unary

Hi, @Dig-Doug, thanks for working on and releasing this great work. Are there any blockers on merging #69? Currently `.mjs` files are practically unusable as far as I understand and...

Webpack support - Cannot find module 'google-protobuf'

Hi. I'm not sure if you are still looking for a solution, but I solved this by using `umd-compat-loader`. Another solution would be to use `.mjs` output. However, it seems...

remove unnecessary variable assignments

To reduce the amount of work on readability reviewers, please send readability review request after you get LGTM and Ownership Approval.

consider to remove matplotlib dependency

blueoil uses matplotlib only for colormaps (`matplotlib.cm`). Alternatives: * palettable: https://jiffyclub.github.io/palettable/ * colorcet: https://colorcet.pyviz.org/

Consider upgrading to TensorFlow 2.0

@ytfksw thanks for working on this issue. I'm curious how much amount of work is left here. Can you give me an estimate?

print() is not suitable for logging

I think the easiest way is to put ``` import logging logger = logging.getLogger(__name__) ``` at every module top, and use the `logger` object. Other option is to add `logger`...

tf_upgrade_v2 for network/classification/vgg16.py

what's the status of this PR? @iizukak Can somebody else review if you're busy?

Google connector with ADC: unexpected end of JSON input

Thank you for investigating this. Yeah, I also suspect it's because of `JSON` being empty, but I'm still confused because my testing code above worked okay (returning `` config successfully)...

Documentation on new AutoUnboxing wart is missing

I think you are supposed to call `booleanValue()`.