Tom Rybka

icon company @google icon location Cambridge, MA icon location Staff Software Engineer at @google. Primarily working on Build Tools / Toolchains for C++.

Results 37 comments of Tom Rybka

Make strip_include_prefix apply to textual_hdrs

(Replied to the wrong PR...) The goal would be to enable it internally soon as well, but to be able to approve this change without blocking on said clean-up. (The...

`clang-cl` toolchain for x86 (32-bit) binaries is missing

Apologies for missing your PR attached to this issue. If you want to resubmit it we would reconsider, though I suspect the overall demand for 32-bit x86 Windows is dwindling.

Add a `cc_inputs` attribute to include arbitrary files in compilation actions and support location expansion

We would consider a contribution for this, but would like to know a little more about what kinds of things you would envision passing here for CC rules. Maybe for...

Register both windows compilers to enable cross compilation

My understanding of the purpose of BUILD.toolchains.tpl is to register exactly one toolchain for targeting "your host." This would seem to be a divergence where, on Windows, we register cross-compiling...

Register both windows compilers to enable cross compilation

> > How do other folks handle this? I assume most folks doing cross-compilation manually register a different set of toolchain(s)? > > Do we think that Windows developers are...

Allow `includes = ["."]`

I think includes `"."` translating literally to `-I.` could be problematic as the includes are viral (i.e. they get added to all things which depend on this, but the `.`...

Allow `includes = ["."]`

So I don't think we want to allow literal `-I.` on the command-line, but if the [strip_]include_prefix combo worked I think we'd be open to making that easier to spell...