Tom Rybka

Results 37 comments of Tom Rybka

I'm also wondering if something other than `%sysroot%` as a prefix would work better (e.g. `%workspace%`) More info on the include dir prefixes here: https://cs.opensource.google/bazel/bazel/+/master:src/main/starlark/builtins_bzl/common/cc/cc_toolchain_provider_helper.bzl;l=103-122;drc=f2318d2cbf38d249d620dc99a11570843306a6fa

Just adding that this was (re-?)discovered as part of trying to land https://github.com/bazelbuild/bazel/pull/25750. The TL;DR was that we're trying to roll this out in a repo where we expect to...

AFAIK if your toolchain has `supports_start_end_lib` feature enabled, archiving actions are not run. Can you provide a reproducer?

I missed the part where you're building `//...` which would build the `cc_library` targets directly. My mistake. I don't know that we have a great answer here except that building...

Nope. My misunderstanding of the initial request.

I believe this is intentional. In theory this should include very few (if any) headers, and they be simple and co-located with the `.cc` file. I would say they shouldn't...

I'm admittedly not well-versed in how cross-repo includes work in this scenario. The way your rules are setup, I would have assumed `foo:main` as built via `ersatz_main` would still be...

Based on the docs and the implementation, I would say that any use of headers that happens to work is probably restricted to mono-repo only. This is kind of the...

> I found it super handy to put a print inside `src/main/starlark/builtins_bzl/common/cc/cc_toolchain_provider_helper.bzl` and print out `toolchain_config_info`. That shows the exact crosstool protocol buffer being fed into bazel, if I'm reading...

I think we could handle it in semantics.bzl rather than a flag or a feature. The former would need to either be in Java or Starlark Build Flags both of...