Tim Rozet

Results 83 comments of Tim Rozet

@girishmg @hzhou8 @tssurya @dcbw

thanks @cathy-zhou @winsopc . Do either of you happen to have the pprof file or graph output you can share? I'm guessing the problem is this function: ``` func forEachNBTemplateInMaps(templateMaps...

So the code @ricky-rav added skipped the service add stuff during RequestFullSync on initial start up, but it did not skip c.syncNodeInfos(nodeInfos): https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/ovn/controller/services/services_controller.go#L527 This ends up calling svcCreateOrUpdateTemplateVar for all...

@winsopc thanks. I think that proves the theory. Can you or @cathy-zhou try removing those lines I mentioned and see how it goes?

good point @dceara. We still need new node add to work, but we can conditionalize the full sync on the startup lock. So I think you can do this @cathy-zhou...

I'll submit a new PR that includes the fix I mentioned.