Matteo Vitali comments

Results 10 comments of


                                            Matteo Vitali

Rename solidus_backend to solidus_admin

I have the code ready for this issue, can I pull a request?

fix #23 Last feed entry is duplicated infinitely

Is there any chance that this PR will be merged soon?

python:3.11-slim-bookworm CVE-2023-5752

Hi @LaurentGoderre Is it not necessary to modify the pip version here as well? https://github.com/docker-library/python/blob/8bc80d1109001365559eded16423ba3692eff1ff/3.11/slim-bookworm/Dockerfile#L137 (and in the "not slim" bookworm also) https://github.com/docker-library/python/blob/8bc80d1109001365559eded16423ba3692eff1ff/3.11/bookworm/Dockerfile#L103

Doesn't work on a Inline Admin Page

+1 is there some solutions?

Fix #7 required email constraint

Hi @carltongibson I opened this pull request with a bit of calm. I admit it's quite extensive, and perhaps some parts might be out of scope. Many things could potentially...

Fix #7 required email constraint

> Like what? Sure you have to migrate the table (add the constraint) but (on the assumption your data isn't incompatible) what's to stop you migrating forward and backward multiple...

User.email field is not mandatory and remain `blank=True`

> Tests for the `ModelForm` behaviour should check this too at that level. > > We can mung the validation exclusions at the form level, so that may need some...

User.email field is not mandatory and remain `blank=True`

Hi @carltongibson I took a look at the `_get_validation_exclusions()` method. I admit I'm not very experienced with forms, so feel free to correct me if you think I'm not heading...

User.email field is not mandatory and remain `blank=True`

You're right, the draft code linked before is not ready for a PR yet, and there are still some things to be fixed, including missing tests. However, from a human...

Use `distroless` for a more secure and minimal Python Docker image

> All being said, I see potential with a multi-stage build, and it could address some of the concerns mentioned in the issue. A multi-stage approach with a single Dockerfile...