Timo Rößner

Replace Hash with Set in RecursionGuard.

3

While browsing IceNine's codebase I noticed that we can replace the Hash in RecursionGuard with a better fitting Set since we don't need the values.

Follow-up to #1065 The UncommunicativeVariableName smell detector: - does not take the context into account, hence context based configuration via comments or config file is not working - does not...

TooManyMethods: discern between public / non public

5

Follow up to #641 Suggestion: 5 public methods, 10 private methods max. WDYT?

Make releases less noisy

3

Since we are explicitly putting version numbers in our documentation links our releases have become very noisy as you can see in #1391. Ideally, there would be one cucumber feature...

[WIP] Allow users to include other configuration files.

3

Fixes part 2 of #1411

A strategy for making our --todo feature more useful

3

As I mentioned in #1406 I have been working on improving our todo list functionality so that the TodoCommand recognises if there is a configuration file present (either the default...

Coming from #1102 there's only one thing left to validate when it comes to configuration via source code comments: That the datatypes given to our basic and custom configuration options...

Initialising instance variables to nil

8

Coming from [here](https://github.com/troessner/reek/pull/959): I'd consider initialising instance variables to nil is its own smell. There is no semantic difference between: ``` Ruby class Omg def initialize; @bar = nil; end...

Run Reek against rubyspec

5

I recently had a chat with @mbj and he suggested the following: > > Also I run all checkins for mutants generation engine and unparsers round trip against rubyspec that...

Seriously, that thing is getting way too big.