Gabriel P Stone
Gabriel P Stone
Hello! Just tried compiling the tests as-is with `Nim Compiler Version 1.6.2 [Linux: amd64]`. All work except for `tchipmunk`, but that seems to be known per the commit messages, and...
Just to throw my "two cents" in as it were: There are quite a few issues where this is talked about here... [667](https://github.com/sickcodes/Docker-OSX/issues/667) [511](https://github.com/sickcodes/Docker-OSX/issues/511) [571](https://github.com/sickcodes/Docker-OSX/issues/571) [715](https://github.com/sickcodes/Docker-OSX/issues/715) ...with somewhat related PR's...
GH-32206: Added back a line I had erroneously removed (`port_` argument for `storage-testbench`).
> `gcsfs.h` is a public header. So this is a breaking change. Could you keep `**This PR includes breaking changes to public APIs.**` in the pull request template? This has...
Tests were re-run locally as a result of the local compilation of commit 49fd6d0e0a4fefadc7083e5e4fa392c3528669cf; `arrow-gcsfs-test` was successful. (EDIT: incorrect commit hash).
Tests were again re-run locally as a result of the local compilation of commit e5b606e462cb362ef49092eb10797d166e2e60fd; `arrow-gcsfs-test` was successful.
> Could you fix lint failures by `pre-commit run --show-diff-on-failure --color=always --all`? I think those failures should be fixed now (ref 07c36f5786888c1e2398cda5911bc4f986fe30f4 & bc88c9ffe39d1d8c5e3ebb8b5ecb63b7aedf975e).
I apologize sincerely for the linting back-and-forth; just committed another change (ref f0ba9c5cec42962c5b9fde69d3734ec6367ce9ef) to match method signature style to nearby method. I appreciate everyone's guidance & advice as I work...
> Why did you fix it manually? Did `pre-commit run --show-diff-on-failure --color=always --all` not work well? That's correct it did not, but after further investigation it turns out it was...
@kou The C++ linter tests that previously failed went through & succeeded, but the R tests are still failing. However, I'm assuming that isn't a consequence of this change?