Josh England

Just wanted to point out that the README.md still references the CHANGELOG.md for this project as an example of the output. I understand not wanting to maintain the changelog for...

LeagueMarkdown converter is explicitly requiring CommonMarkConverter

2

League CommonMark: v1.6.6 Twig Markdown-Extra: v3.3.3 Twig: v3.3.3 The `LeagueMarkdown` constructor is requiring the `$converter` parameter to explicitly be an instance of `CommonMarkConverter`, however with League CommonMark v1.6, the converter...

Ability to listen to various events that aren't currently exposed

5

I'm having to directly add a listener to the input element to listen for blur events so I can do a proper check for if a new value has actually...

Enable strict comparison for arrays of scalar values

5

With the change in v1.5.0 that enabled strict `in_array` checks, if an array of objects is passed, it is strictly checked instead of doing a more passive check on the...

Client::createSubscriptionChange() returning EmptyResource throws Fatal Exception

6

_Warning_: Github issues are not an official support channel for Recurly. If you have an urgent request we suggest you contact us through an official channel: [email protected] or https://recurly.zendesk.com **Describe...

So, it's not a major issue but I ran into something that took me way longer than it should have to figure out. For some reason, `OneLogin\Saml2\Auth` kept errorring when...

Rediska_Serializer_Adapter_Json::unserialize returns same value that was passed in

1

The Rediska_Serializer_Adapter_Json::unserialize method is returning the same value that is being passed in to be unserialized. Please see below: Lines 88-97 ``` PHP public function unserialize($value) { $decodedValue = json_decode($value);...

Warning: Unterminated comment starting

2

I can't tell why this is being thrown, but whatever class was being processed apparently causied `$tokens = token_get_all("");` to throw this warning. ``` Warning: Unterminated comment starting line 1...

- updated tests to use lodash instead of underscore - updating dependency information - introduced mocha-phantomjs to enable CLI test running - added peerDependencies to package.json

The "main" property has to be a string. Using "files" is the proper approach for npm