Trevor Riles
Trevor Riles
Currently very interested in this work. What are the blockers for this being merged?
> There was an LFX project that was a superset of this functionality: #5505 > > Maybe @saswatamcode or @matej-g have some information on how far that got and whether...
What are the blockers here? I would love to help push this across the line.
@chriskuehl you mentioned that there is some changes that have made it to develop but not been released yet. Would it be better for us to target a release branch?
I've got develop merged in and all the tests passing. I'll begin addressing the other PR comments next. One thing to note is that opentelemetry-python doesn't officially support 3.12 yet,...
@chriskuehl I'm curious what your thoughts are on the lack of 3.12 support at the moment? https://github.com/open-telemetry/opentelemetry-python/issues/3617
> This looks reasonable but given the size it's difficult to catch any bugs during review. I think we should discuss how we want to test this before the final...
In this scenario would `default.nix` and `release*.nix` be the same thing?
After chatting with @redloaf, my understanding is that the httpbpv2 and thriftbpv2 libraries are in alpha and almost ready to ship. The cleanest path is likely to push for services...
Should the `InjectServerSpan` logic already be short circuited by this code when using the transition library, without the need to remove it entirely? https://github.com/reddit/baseplate.go/blob/c7e065837fc5906607a660629fb6f9cb08e3247d/thriftbp/server_middlewares.go#L149-L151 Removing them won't break interop, but...