Tam Tran
Tam Tran
Hi @slandelle, I already updated the pull request to fix your comments. Please take a look. Thanks
Hi @slandelle, @TomGranot have you got time to take a look into this pull request again? If there is no issue, we really want to merge this PR to master...
I am working at Wego(https://www.wego.com) - a travel search engine based in Singapore. Our backend will send http requests to our partners to get best flights/hotels deals and display on...
@unoexperto I want http client to distinguish between different calls, the next request shouldn't add cookie from the previous http response.
@unoexperto it's not safe to use `asyncHttpClient.getConfig.getCookieStore.clear()` before making new call because it's possible after you clear, some http responses (with the same URI) come and cookie will be added...
@unoexperto You mean 1 client for 1 new request? Pool of clients will cause performance issue as it will create a lot of threads, event loop... From the design, 1...
@slandelle Yeah, we have many partners. Most of them use API with token, but other partners are using cookies as their credentials information. Could you look at the logic here...
@slandelle Got your idea, thanks. But if we introduce CookieStore at request level, will be cookies set back from global cookie store when we send a new request? https://github.com/AsyncHttpClient/async-http-client/blob/master/client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClient.java#L193-L207
Do you want me to keep global CookieStore or remove it completely?
Hi @slandelle, I just created the PR https://github.com/AsyncHttpClient/async-http-client/pull/1567. Please help to take a look.