Tim Adowski
Tim Adowski
I'm using the input file from the bimodal test to solve a simple inverse problem using MLSampling, but the HDF5 output seems bugged. I set `ip_ml_last_rawChain_dataOutputFileType = h5` and it...
The `if` statement [here](https://github.com/grinsfem/grins/blob/master/src/strategies/src/error_estimator_options.C#L92) contains an OR where both arguments are the same. Is this just accidentally redundant or were one of these arguments supposed to be something other than...
First attempt at a refactoring of `SteadyMeshAdaptiveSolver` so that the visualization output does not get overwritten on every AMR step. The new input flag `vis-options/output_every_amr` is set to false by...
The `conjugate_heat_transfer` example was added in PR #409 but never gets installed through `make install`. I can do a quick PR to fix this, but I wanted to know if...
Looks like CPPUnit removed the `bin/cppunit-config` file in `1.14.0` which breaks the autotools linking. CPPUnit `1.13.2` still has this file though, so that is the latest version we can use....
Due to a copy/paste error, I accidentally set the velocity BC to: type = 'mole_fractions' X_CO2 = '0.001' X_N2 = '0.999' This segfaults in `opt` and gives `Failed to convert...
The Spectroscopic Absorption QoI (PR #46) does not account for the different molecular weights of isotopologues, and instead uses the weighted average provided by Antioch/Cantera. Calculations have shown that the...
There should've been an error for specifying boundary conditions for the pressure variable, but there wasn't.
Per @pbauman's request, might be a good idea to `GRINS::GRINSPrivate::VariableWarehouse::clear()` when a `GRINS::Simulation` object is destroyed to prevent interference if another `Simulation` object is later created again.
Found an issue with analytical Jacobians in LMNS.C from PR #183, which was fixed in #184. However, LMNS tests from `make check` did not catch this error. Need to improve...