Torkel Ödegaard

Results 91 comments of Torkel Ödegaard

@JoaoSilvaGrafana i don't think controls are that useful , showing component in all its states / use cases are 10 times more useful than a single component where you have...

@leventebalogh >> Plugins need control over page layout: full width (ie dashboard layout) or with section nav. > Is this something that we can guarantee? (I mean if the plugin...

@ashharrison90 thanks for the review! yes this was much harder than I thought it was going to be (and I already thought it was going to be tricky). > are...

This is likely due to the queries missing maxDataPoints and intervalMs (two properties that are added in the frontend) https://github.com/grafana/grafana/blob/main/pkg/services/publicdashboards/service/service.go#L185 The type here is strange, Queries is untyped https://github.com/grafana/grafana/blob/45750da66758744061f3687184f47af5a606a076/pkg/api/dtos/models.go#L69 it...

Missing new page layout with new SectionNav component There are things here that are a bit related that we need to figure out. * NavModel / NavModelItem , what should...

Sorry for the massive PR, I realised a bit late that there was a way to not solve everything in one PR (So Links and Versions compare does not support...

@ashharrison90 > feels like this section header should be the name of the dashboard (instead of just Dashboard) to match the breadcrumbs: Logically yes, but it somehow felt confusing. *...

@axelavargas added a "+ new variable" button, good catch! the issue with delete not removing the variable state from URL is an issue before this PR (likely existed forever). Also...

> the changes have made the experience of using the settings easier indeed. I tried hard-reloading of the page when I am on DashboardName > Annotations > A Test Annotation...

> i think we can solve the a11y thing without reverting back to divs, but i don't wanna suggest that and be wrong and i don't want it to hold...