Tor Colvin

Results 8 comments of Tor Colvin

i think using `pytest.hookimpl(trylast=True)` could be a good idea in the use case I have this case, but if more than one plugin registers a teardown hook, we can end...

> Hm, got a single test failure: in "test v8 (ubuntu) (pull_request)" the test TestReconnectReplicator failed: > > ``` > 2023-06-07T23:42:31.2727087Z utilities_testing_resttester.go:199: > 2023-06-07T23:42:31.2727596Z Error Trace: /home/runner/work/sync_gateway/sync_gateway/rest/utilities_testing_resttester.go:199 > 2023-06-07T23:42:31.2728496Z /home/runner/work/sync_gateway/sync_gateway/rest/utilities_testing_resttester.go:203...

I was thinking about changing `sgbucket.DecodeValueWithXattrs` to return `map[string][]byte` for xattr values so the caller doesn't have to loop over them again.

When looking at this PR, evaluate this for safety to put into 4.0.2 to address CBG-5017 and obviate the need for https://github.com/couchbase/sync_gateway/pull/7890

To consider: Is the latest set of changes better than https://github.com/couchbase/sync_gateway/pull/7892/files/eb809bf36ded144a008de3741c629a11a999d827 ? Does it add more risk to the ticket to make it not worthwhile? The idea behind the latest...

> To consider: > > Is the latest set of changes better than [couchbase/sync_gateway/pull/7892/files/eb809bf36ded144a008de3741c629a11a999d827](https://github.com/couchbase/sync_gateway/pull/7892/files/eb809bf36ded144a008de3741c629a11a999d827) ? Does it add more risk to the ticket to make it not worthwhile? The idea...

This looks right but I was having a look at the rest of the API and I have some questions about potential clarifications. I'd probably make the description for POST...