Antonio Brewer comments

Results 64 comments of


                                            Antonio Brewer

ReadMe.md Lines 6 & 14 Connecting Teensy to Transceiver

TX to TX, RX to RX. Just like UART, you won't blow up anything if they're backwards, it just won't work.

ESR1 SYNCH

This flag is more or less if the controller participated on the bus, regardless of bitrate. Your baud could be bad but still the SYNCH flag may be set. You'll...

Bus Off Recover

The controller does this by default (autorecovery), you may disable this but handle the ESR1 manually if the BUSS OFF state is triggered in order to manually get it running...

Store strings inside library, instead using external char *

char arrays are preferred over Strings, Strings will eventually break your program in the long run due to it’s dynamic allocation

Store strings inside library, instead using external char *

...and causes memory leaks...

Store strings inside library, instead using external char *

const char* doesnt waste memory, it uses storage, same as PROGMEM.

Store strings inside library, instead using external char *

on teensy, const is automatically out in flash during compile, no need for progmem or F() macros, the static print/println() are stored on flash as well without F() macro surely...

Store strings inside library, instead using external char *

how would it panic out of setup() scope? you do realize, internally, the class stores the username/password. i fail to see how a panic would occur “out of scope”

Store strings inside library, instead using external char *

i would also refrain from using STL c++ containers, they use dynamic allocations and adding Strings to the mix is bad, especially if the user is using interrupts. vectors (one...

Store strings inside library, instead using external char *

for classes as well, when initializing i would never put a variable storage as a const or a pointer, i prefer copying it directly and using the internal copy in...