Tony Cabaye

Results 78 comments of Tony Cabaye

I just test this package I found really great, but I think the header problem is still present. See https://github.com/tonai/react-deploy/commit/9057ee81875c4972d26da658c75c3828156ab99e I have `### 0.1.1 (2020-10-13)` but it should be `##...

Ok I miss the fact that for the first release you should run `npm run release -- --first-release`. It looks better: https://github.com/tonai/react-deploy/commit/797d7240ec3c5df3b6897fa7f0e9c7a0b7513748

It still looks a little odd for patch releases: https://github.com/tonai/react-deploy/commit/b44911e45ca9861df4cc191aa116e5381e8c8de0 It is ok for minor release: https://github.com/tonai/react-deploy/commit/2cdadf4acff8940bc648e6570fe8be32fdbafa79 Is it something that is wanted ?

Hello @fvsch and thank you for reporting. If the button (used to switch theme) is not rendered in the UI, the theme will not aply. We can try to fix...

Hi @CodeByAlex in fact each framework need its custom decorator development. I can check when I have some time.

Hi @CodeByAlex , I started to have a look to implement Angular but there is some difficulties and maybe you can help if you want. The decorator is [here](https://github.com/tonai/storybook-addon-themes/blob/feat/angular/src/decorators/angular.ts) on...

Hello @CodeByAlex here is a little repository that reproduce the problem : https://github.com/tonai/storybook-angular

Hum I don't really understand your question @CodeByAlex . The setup of the decorator in the storybook is the same for all frameworks. Example: ```js import { withThemes } from...

I don't know how custom decorators will be handled for now. If possible I want it to look like a standard Angular component. But before managing the custom decorator option...

@CodeByAlex You can't make the addon framwork agnostic for decorators. The solution I propose without using a decorator is indeed framework agnostic. Bur if you look at the [code of...