Tom van Ommeren
Tom van Ommeren
Perhaps this should be documented (though it's not promised to be anything but global preferences). Unless there are some strong arguments for specific settings I would like to `wontfix` this....
Perhaps after cleaning up the settings in #722, we can come up with some candidates that definitely should be project-specific? For example configuring `completion_hint_type` is very likely a server specific...
Agree that timing is useful to have in LSP!
For performance investigations, developers can make the necessary change to 'logging.py'. Closing until more endusers report a preference for more logging output.
Under what condition could the logic in https://github.com/sourcegraph/javascript-typescript-langserver/blob/2391d4a9b97808a901fff33adbfd9f14c5a1f473/src/symbols.ts#L39 be changed to return a file:// uri? Removing the check fixes jump-to-definition to `ts.nodeModuleNameResolver`, but knowing it only affects the Typescript API...
The restart command had no tests written against it either - I'll have a look at fixing it tonight!
When we had all the code in 1 module, the whole plugin was conveniently restarted by Sublime's module reload. Now the plugin is broken up over several modules, I think...
Ah this is my bad.. I thought stack ide already considered the selection when returning results but seeing this it obviously doesn't. I'll restore the old logic shortly!
Should be fixed, @rvion can you let me know otherwise? Thanks!
Can you make sure your Sublime is running the latest code? The filter_enclosing function should work the same, but could also use some tests (and it wouldn't be the first...