Tom Madams

Results 42 comments of Tom Madams

For what it's worth, the approach of packing commands and command arguments into a data stream is ubiquitous in space or time critical software: video games, computer graphics applications, audio...

I will just say that after having worked on it a little, I personally think a more confusing and problematic issue with the glyph code is that the order of...

Thanks for digging into the glyph code, those missing glyphs have been bugging me too. I agree that the string -> number -> string conversion is less than ideal. This...

I spent a couple of hours hacking on it this morning and it looks like the approach could work. It seems like you have to use [``](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/symbol) instead of ``...

Quick update. I've got the glyphs drawn using `` and `` elements drawing correctly: ![image](https://user-images.githubusercontent.com/7587269/132082362-bc67ac37-7d84-4d26-bec7-94a63f9280cb.png) Only elements that are drawn via `Glyph.renderGlyph` are hitting this codepath for now, which is...

Storing the SVG path in the `*_glyphs.ts` files would be great. And I am 100% behind the idea of reordering the coordinates to match what the `RenderContext`s expect! To completely...

Oh, and yes, avoiding the negation of the y values would definitely simplify the rendering code. I spent about an hour tracking down a bug where the `dynamicPiano` glyph wasn't...

So I cleaned up the rendering code and removed all the extra unnecessary work and the performance is... terrible unfortunately. When the test page is running, Chrome spends nearly all...

Some good news, it turns out that the terrible performance was caused by multiple `` elements in _different_ SVGs sharing the same ID. I was simply assigning the glyph name...

We've added a symmetry-aware inference cache that averages all symmetries for a position, which (assuming an infinite cache) will tend towards returning the average of all 8 symmetries. For example,...