tomasvn

Results 21 comments of tomasvn

``` new Glide('.glide', { arrows: { prev: '.glider-prev', next: '.glider-next' }, type: 'carousel', animationDuration: 1000, // autoplay: 3500, focusAt: '1', startAt: 3, perView: 1, }).mount(); ``` `.glide` should be string,...

@hannasorokina You have to install those plugins as dev dependency, even though it says in the readme that gulp-imagemin comes bundled with those plugins

@gingerchew I have update the PR, can you check it out? I am not sure about the typings of methods and setting private fields

I am not sure about this method `getElementIndex(node: Node) {...}` about the type of the parameter, previously I had nothing, not sure if this is the correct type. Also how...

I have improved upon your suggestions, yeah haven't found other solution rarther than to use unions I have to think about, how it can be improved

![image](https://github.com/biati-digital/glightbox/assets/17225564/07244191-9835-45e2-9215-ddd35a42853f) ![image](https://github.com/biati-digital/glightbox/assets/17225564/bf1c8f60-da3f-4fe5-95cb-02e6e33f08ca) Improved typings @gingerchew

Had to go to reddit, not going to lie :D Well I had to reach out to better TS devs

> Even still, great find! > > I was looking through and found a place where the function arguments don't match up. Here [on line 340](https://github.com/biati-digital/glightbox/blob/0e0dd79cf8452e9f1f84870584b2417a8d45f7f0/index.d.ts#L340-L348) of the `d.ts` file,...

What stuff would you like to see, to be customizable? As basically everything could be moved to css variables, @massimo-cassandro

I am more for the local scope of the class, and if I need to override it, that would be easy, we should not imo pollute the `:root`, as there...