Tomek Wytrębowicz

Results 162 comments of Tomek Wytrębowicz

I updated the `testNoCoveredLines`, but I don't know why [`testWorkingCorrectly` was asserting `No lines found`](https://github.com/exussum12/coverageChecker/blob/master/tests/PhpunitDiffFilterTest.php#L23-L35) in the first place :confused:

It would be great to make it customizable. So, I'll not end up having more line breaks than needed, as it makes diffing imposible

> I think e2e-environment might be unable to load the config using the updated version for some reason. Do you have any hint how to debug it locally? As mentioned...

I also guess it may fail due to lack of appPath to resolve config paths, due to https://github.com/woocommerce/woocommerce/issues/33684

> I don't think so, because other PRs that are up-to-date with `trunk` are passing: https://github.com/woocommerce/woocommerce/pull/33905 :ok_hand: --- > However, we are in the process of deprecating e2e-environment, so I...

Sorry, @alopezari but I'm still pretty much confused. > So yes, you can rely on these Playwright specs to test this PR :) What you suggest [above](https://github.com/woocommerce/woocommerce/pull/33828#issuecomment-1211793226) is to "test"...

Also, speaking of how to run all of that in this repo. `pnpm install` fails, as it requires an old version of `pnpm` to which I cannot downgrade: ``` $...

Through my manual cop'n'pasting & checks mentioned in [OP](https://github.com/woocommerce/woocommerce/pull/33828#issue-1302409247), I managed to test it solves at least one step with setting up admin e2e tests for external extension. Speaking of...

...and here https://github.com/whatwg/html/issues/3219 - for imperative attaching of labelable element to the label element.

Wow, thanks for sharing your ideas! 70x speed up sounds impressive! We will get back to longer discussion once @alshakero is back from vacation, so we could involve entire team....