Thomas Achatz
Thomas Achatz
Thanks for reporting this issue and for the detailed analysis! You are right, the `app.kubernetes.io/managed-by` label should always be set to `crate-operator` in the STS, regardless of what is specified...
Hi again! The fix for this issue has been released as part of crate-operator version `2.49.0`. Please upgrade to this version, and let us know if you encounter any further...
> @tomach wdyt? I would prefer option 1 as well. Most important thing is, that the changes do not break the setup for existing users which were already created `WITH...
Probably also in the operator we would need to add the new backup location type somehow to the `restoreSnapshot` CRD and consider it when creating the repo for restoring a...
Hi @amotl! Thanks for the reminder. I’ll be taking a look at this today. Thanks for your effort and patience! 🙏
I tried to fix all mypy errors in `crate/operator/prometheus.py` and `tests/test_metrics.py`. And changed one fix in `crate/operator/handlers/handle_create_cratedb.py` where I think raising an error if `status.get(CLUSTER_CREATE_ID)` is undefined could cause issues,...
Yes, thank you! I [added it](https://github.com/crate/crate-operator/pull/654/commits/737a1b8d1d95c0fb5868714f5f188080c79110ad) to the `nitpick_ignore` list. Since it is just an interface and there is no official docs for `prometheus_client` on `readthedocs`, this should be fine...
> it looks good to me, but I'll let @tomach have the last word (because he is more aware of that topic than me). LGTM! doesn't seem to have any...
Thank you for the thorough report and insights. To clarify a couple of key aspects: 1) Changing `heapRatio` is currently not supported by the operator - modifications to this field...