Joshua Yarmak
Joshua Yarmak
@tprouvot, Is there a plan to add a settings page?
Hi @tprouvot, Thank you for reviewing this PR. I can explore an option to communicate directly with the content script by posting a message to the popup's parent. This will...
Ok @tprouvot, I'll work on that and post when complete.
Hey @tprouvot, I managed to achieve this new functionality by injecting a script into the DOM, not requiring the new permissions anymore I also resolved conflicts with releaseCandidate Kindly, please...
> The result looks great @toly11 👏 I checked if we could also use the navigation for internal shortcut links `onDataSelect` for `AllDataBoxShortcut` class and it seems to be OK,...
> No I'm talking about those links which can redirect to setups links such as `Deployment Status` > > Just got a chance to review this. I’d be happy to...
> Few remarks concerning the inject.js script, today it is inserted in the page even if the user doesn't interact with the extension. I would prefer to inject only when...
> Last thing, could you remove the debug logs Do you think we should also remove the debug when Lightning navigation fails? (addon/inject.js:19)
> and add some comment explaining why you created a inject.js file instead of scripting permission (basically to make the extension work with less permissions which can lead to company...
> Hi @toly11, > > I've addressed the suggested action on how-to file and option page. Did you create a suggestion, or should I create a new commit?