Tokoro
I am having the same issue. A quick inspection of your test case with `verible-verilog-syntax --printtree` shows the following: ``` ... Node @5 (tag: kParenGroup) { Leaf @0 (#'(' @65-66:...
I'm not sure if this could be a proper solution, but here is a patch for this issue: https://github.com/tokoro10g/verible/commit/9a92aaa6feac68a30e91bc9fc230793f1d6dda9b
Thank you for the consideration! I would also like these backported: - https://github.com/ros2/ros2cli/pull/800 - https://github.com/ros2/ros2cli/pull/802 They also looked straightforward and not breaking anything. I have not checked all the options,...
@henningkayser Thanks for your attention to this PR!! I could have explained it more clearly... For example, `abc.def` containing `.` is a valid name for a parameter, https://github.com/ros2/rclcpp/blob/7f7ffcf6ed1143b4d4a9e0cf248e190731b2e5f8/rclcpp/include/rclcpp/node.hpp#L502-L504 but not...
@henningkayser Yes, exactly.
@henningkayser Hi! I really appreciate your review! Please let me know if you have any further questions or suggestions on this change!
@henningkayser Friendly ping! cc: @DLu
@DLu Thanks for the kind reply! > It seems odd to have to do the same thing in each package. Agreed, and there are none as far as I could...
Any updates on this? I agree with everyone here pointing out how the colorless output bothers developers. I believe this PR will improve the DX of colcon pretty much and...
@bfmatei @Sergej-Vlasov Let me know if any clarification is needed. Thanks!