Todd

Results 8 comments of Todd

@codeling Please see how this is handled in VTK, where the unicode policy is UTF-8 everywhere.

What is needed is to replace _Ifstream/iostream_ in METAIO with their vtksys equivalents, as has been done in VTK and Paraview e.g. https://gitlab.kitware.com/paraview/paraview/-/merge_requests/3850 The METAIO_STREAM macro can be used to...

Sorry but I think introducing the _MET_FromUtf8ToLocalEncoding/MET_FromUtf8ToLocalEncoding_ macros is a terrible idea. Please don't redefine _ToWide()/ToNarrow()_ in the METAIO source as they are already defined in KWSYS. The best way...

> correct me if I'm wrong, but wouldn't making MetaIO depend on vtksys introduce circular depencies (since currently VTK depends on MetaIO? Since MetaIO and VTK are separate projects I...

`Also I'm not sure the vtksys fstream would fix this issue - it's about the encoding of the .mhd file content, not about the file name` Please re-read the issue....

> I wrote https://github.com/Kitware/MetaIO/issues/68 ;) - maybe it's not fully clear from the description there, but the issue (which this pull request tries to address) is that the content of...

> Of course, there are probably better names than MET_FSTREAM :) **METAIO_STREAM** https://github.com/Kitware/MetaIO/issues/106#issuecomment-1210615022

This is a 5 minute fix. Is it going to languish for another 18 months?