Toby Lawrence

This would be extremely helpful for a particular issue I'm working on. As @sfackler points out, the major sticking point seems to be where `tonic` meets `axum`. Without this, the...

@ktff Admittedly, seeing `Currently we don't retry on response OK 200 that has errors. Because of it, events in that request are dropped.` doesn't make me feel very good. I...

Hmmm, alright. I'll/we'll take another pass this week. Apologies overall for the slow review here: we're trying to avoid getting stuck with code patterns that we aren't confident in, and...

@gmicouin Do you mind providing references to the documentation used to show why this should be valid?

@gmicouin No worries, your change is totally valid. My main question would be: it sounds like, from the PR description, you tested this against Elasticsearch 7.12, but did you also...

> Yes I test this code with Elastic 8.x, and without this change the Elastic server 8.0 does not accept the request. > > Yes you're right, I have forgotten...

@xdatcloud We're super close! As I mentioned in my [initial review](https://github.com/vectordotdev/vector/pull/12927#pullrequestreview-1057621480), we'll need an integration test for this to ensure things work whether using the default compression scheme, or the...

> The Snappy/Protocol Buffer has been the default mode of Loki sink while pushing: Ah, yeah, fair play. 👍🏻 The two additional integration tests look good to me. Giving it...

@xdatcloud Ah, woops: looks like there's still some lints being hit. Most of them are pretty straightforward, and you can work through them locally by running `make check-fmt check-style check-clippy`....

@xdatcloud It looks like you fixed the Clippy issues, but not the other linter issues, specifically our style checks (trailing newlines, spaces, etc). As mentioned above, you should be able...