Todd Nowacki comments

Results 186 comments of


                                            Todd Nowacki

[Move analyzer] Updated package info & clap usage

I'll leave this to @awelc

[Bug] Unused variable error happens when it used

A bad error message, but it is finding something! The initial value is not used, so you could have `let my_counter;`

[Feature Request] Support underscores in number literals

cc @damirka

[Bug]panic in debug mode when invoking status_type() if status is VMStatus::Error{ StatusCode::OUT_OF_GAS }

This isn't really a bug, in that you shouldn't be making an `Error` status with `OUT_OF_GAS`, it should be an execution failure

[Bug]panic in debug mode when invoking status_type() if status is VMStatus::Error{ StatusCode::OUT_OF_GAS }

> a lot of StatusCode's status_type() will return StatusType::Execution Thats why there is an assert to make sure they aren't marked as errors in the wrong category > And regarding...

[Bug]panic in debug mode when invoking status_type() if status is VMStatus::Error{ StatusCode::OUT_OF_GAS }

I'm not sure I fully understand the question. The location for the error is setting is all rather manual at each site, but is informed by contextual information

[Bug]panic in debug mode when invoking status_type() if status is VMStatus::Error{ StatusCode::OUT_OF_GAS }

Gotcha, I'd be okay with saying then that its an execution error... or an out of gas error :)

[Bug]panic in debug mode when invoking status_type() if status is VMStatus::Error{ StatusCode::OUT_OF_GAS }

Sorry yeah to be clear what I had meant. I'd be okay with with this ` debug_assert!(code.status_type() != StatusType::Execution || code == StatusCode::OUT_OF_GAS);`

[Bug]panic in debug mode when invoking status_type() if status is VMStatus::Error{ StatusCode::OUT_OF_GAS }

This would be consistent with the check in `keep_or_discard`

[Design Task] Guidelines and tooling support for Move code portability

I think you might want to flip tier 4-5? I feel like you might want to itnroduce storage concepts before you do entry points I think the tier system definitely...