tnkrxyz

Test deployment: https://thegraph.com/hosted-service/subgraph/tnkrxyz/makerdao-ext validation dashboard: https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/tnkrxyz/makerdao-ext&tab=protocol

Make these two fields of the Market entity in the lending protocol optional, outputToken is already optional. - outputTokenSupply - outputTokenPriceUSD

Rename PositionSide.LENDER to PositionSide.Collateral or Depositor in extended lending schema? Protocols like makerdao do not lend collaterals (only DAI); it is a bit odd to call them the lender side.

Make the liquidate.position field a list in the extended lending schema, because multiple positions will be changed by a liquidation (lender and borrower side).

> It seems like MakerDAO has been upgraded to lending protocol schema 1.3.0, but the schemaVersion response from the subgraph is still returning 1.2.1 Will fix this in PR #555

Status of issues reported by @bye43 in PR #555 (temporary deployment with current implementation available at https://api.studio.thegraph.com/query/29379/makerdao-ethereum-v2/v0.0.2) **Protocol Metrics** | Section | Metric | Issue | Status/Note | | -------...

With #555 merged, this issue is now closed. Please comment/re-open if there is any remaining issue.

Thanks for the QA report - looking into these.

> Reopening > > Description Value > Subgraph Reviewed https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/id/QmXH6LgaK8RfwZrqCL2JT5137hpbWRU2oLBsm7seyjJgVi&tab=protocol&version=pending&name=messari/makerdao-ethereum > Date Reviewed August 12 2022 > Schema Version 1.3.0 > Subgraph Version 1.1.0 > Methodology Version 1.0.1 > Evidence...

Read a bit more on the liquidations on 3/12-13, 2020, it seems the situation was more complex: the high protocol side revenue from liquidations was on paper - the vat...