Brent Christensen
Brent Christensen
@joshfeck we need this extra precision in the EDTR in order to accurately reverse calculate ticket base prices from the final total (see https://github.com/eventespresso/event-espresso-core/issues/2851). I looked at the template where...
unit tests were failing so had to apply some more changes, mostly because tests were based on decimal places getting rounded off at 2 (sometimes hard coded as such). reg...
check out this error that happened during unit testing on TRavis: ``` There was 1 failure: 1) Events_Admin_Page_Test::test_delete_event The following error(s) occurred during test "Events_Admin_Page_Test::test_delete_event()" : An error has occurred:...
@garthkoyle no, that setting in the Countries admin is just for display purposes, whereas the increased decimal precision added in this PR is for internal purposes only to reduce rounding...
oh dang it... just rebased onto the wrong branch 🤦🏻♂️ welp... that explains all of the conflicts 😖
Keep getting these stupid JS unit test failures: ``` TypeError: (0 , _i18n.isRTL) is not a function ``` as you can see here: https://github.com/eventespresso/event-espresso-core/pull/952/checks?check_run_id=1666273126#step:6:2892 whose stack traces all end at:...
@joshfeck OK try that out now... basically I've gone through and found places where any kind of "unit price x quantity" type calculations were being performed and ensured that those...
ok plz try this again Josh
@sethshoultes it appears you have found a get rich quick scheme! good catch, will fix