Tomasz Miąsko

Backtrace is not signal-safe and shouldn't be used from a signal handler. This is also true of println and assert macros.

Whether signal is generated in synchronous or asynchronous manner doesn't change the fact that the signal handler can only use async-signal-safe functions. Take for example one reason why this crate...

This could be addressed by using similar organization of builtins as one in libgcc, as suggested before. The only challenging aspect of that work is that partitioning is controlled through...

Testing with compiler-builtins 0.1.68, the original steps still reproduce the issue for me. Panics originate from arithmetic operations that perform overflow checks: ```console error: linking with `cc` failed: exit status:...

My general experience from testing the lint with limit starting from around a few kilobytes, is that it is very likely to lint about copies of large structs. This is...

This general pattern for copying the data appears to be opaque to memcpy optimizations, i.e., every single transformed copy remains. Any ideas how this could be improved?

As you prefer. The current implementation is not that far from the point where we could run some tests on it. The one missing component is a mapping from a...

> mapping discriminants to variant idxes is not guaranteed to be 1-1, is there anyway to check that? The `InterpCx::read_discriminant` exercises related API and contains explanatory comments, might be good...

In terms of placement in MIR pipeline, I would put it towards the end, somewhere after SimplifyLocals, maybe just last? I wouldn't expect it to create any new optimization opportunities.

This test would be `src/test/codegen/consts.rs`? I think we should keep the test. The enums there shouldn't qualify for the transformation once we use proper threshold. For the time being, you...