Tom Hodgson

Results 11 comments of Tom Hodgson

Has there been any movement on this ? Thanks !

has there been any progress on this at all? Currently unable to build because the rule to be documented uses `java_binary/java_library` from rules_java. 'documentation generation failed: File external/rules_java/java/defs.bzl imported '//java/private:native.bzl'

> > has there been any progress on this at all? Currently unable to build because the rule to be documented uses `java_binary/java_library` from rules_java. > > 'documentation generation failed:...

> From a brief glance, spiffe id is incorrect. Normally it would be `spiffe://{WORKLOAD_POOL}/ns/{NAMESPACE}/sa/{KUBERNETES_SERVICE_ACCOUNT}`, where WORKLOAD_POOL is `"{PROJECT_ID}.svc.id.goog"`. Not sure if the first foo in `spiffe://foo.svc.id.goog/ns/bar/sa/foo` is the same as...

> Which Java version are you using? I'm suspicious that it may matter. > > It seems weird to me that `foo.bar` is getting checked from the JDK's `checkServerTrusted()`. The...

stepping through I see that after disabling the check in sslParams, `setSSLParameters` in `SSLConfiguration` is ignoring it : https://github.com/openjdk/jdk/blob/8e12053e0352a26ecd7f2b9bc298ddb8fb4bb61b/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java#L312

Hey @satyanandak took a look, lots of unknown host exceptions for github.com and storage.googleapis.com Can it be re-run?

@satyanandak @sgowroji sorry I can see the checks got re-rerun but the test logs still show host exceptions for github and storage.googleapis.com Can someone take a look ? Thanks

just by including the xds library when building Bazel means we can give it an "xds:///" address for remote builds/caching and it understands how to resolve it