Thomas Meckel
Thomas Meckel
@jfhbrook-at-work can this be merged any time soon? I'm currently struggling with a migration that contains a couple of functions that can only be deployed to the database schema as...
@jfhbrook-at-work thanks for the quick answer! So, for me it seems I either have to build a version on my own with this patch included or I wait for the...
@jfhbrook-at-work Okay, so the open issues are the ones @dhui mentioned in https://github.com/golang-migrate/migrate/pull/666#pullrequestreview-913412810?
@jfhbrook-at-work I just had a quick look how the stuff is implemented in the Postgres driver. Very straight forward. But I don't want to simply "hijack" the PR. @glebteterin will...
@glebteterin seems to me that the GitHub build agent wasn't able to start the database containers correctly. When I look over the build logs every single database test failed because...
@Fontinalis YEAH πΊπ» can't wait to get this merged ππΌ π
> @tmeckel Gonna check it one last time and merge it either this weekend or Monday. Had some last minute things coming up.. @Fontinalis will this PR merged soon?
CommonResourceHelper.psm1: Consider Importing via NestedModules in xPSDesiredStateConfiguration.psd1
Currently the PSD1 doesn't limit the number of cmdlets to export because `CmdletsToExport = '*'`is used. Could it be feasible to add the required *-TragetResource cmdlets from the resources to...
CommonResourceHelper.psm1: Consider Importing via NestedModules in xPSDesiredStateConfiguration.psd1
Hmmmm ... What I initially meant was adding the *-TargetResource functions for every resource into `CmdletsToExport ` in the PSD1 file and import the common helper module as proposed by...
CommonResourceHelper.psm1: Consider Importing via NestedModules in xPSDesiredStateConfiguration.psd1
Interesting discussion about this (precedence of CmdletsToExport and Export-ModuleMember) in the PSScriptAnalyzer repo :-D https://github.com/PowerShell/PSScriptAnalyzer/issues/434 Especially this statement https://github.com/PowerShell/PSScriptAnalyzer/issues/434#issuecomment-178151123 Perhaps we can then create a PSScriptAnalyzer rule that tests if...