Takafumi Arakaki
Takafumi Arakaki
Hmm... It's a bit puzzling that the error occurs at such a late phase. Is this from a public repository? Can I see a CI log?
Yeah, this has been in my (although rather low-priority) TODO #37 but let's track it here.
Sounds good. FYI what I was thinking was to add a proper error handling in https://github.com/tkf/BenchmarkCI.jl/blob/06d4d2b61f088a33746367cab044edeaf516087c/src/BenchmarkCI.jl#L286-L301 (jill.py looks nice! BTW)
I don't object for excluding #39980 due to #42007 *per se*, but #42007 is a performance problem and this is a correctness problem. So, if #39980 solves this issue, I...
Right, that's a fair point. It's good to be cautious.
@StefanKarpinski Are `f(1 + _ in A)` and `f(in(1 + _, A))` different in your suggestion?
> do this in DiffEqBase We can define `algorithm(name::Symbol)` and `algorithm(::Val)` (which throws an error to indicate which package to load to use such algorithm) in `DiffEqBase`. But I think...
Well, it's good news for me if it's (likely to) going to happen eventually.
FYI, there's a setting to run the benchmark with label. Take a look at the setting with `if: contains(github.event.pull_request.labels.*.name, 'run benchmark')` in https://github.com/tkf/BenchmarkCI.jl#create-a-workflow-file-required (thanks to @johnnychen94; ref https://github.com/tkf/BenchmarkCI.jl/pull/65) As for...
> * cleanup where things like `find_libpython` should live. I'd suggest PyPreferences. I think it'd be nice if all the code currently in the `deps` is in some functions of...