Toshiki Kamiya

Results 8 comments of Toshiki Kamiya

I noticed that commit 69a040e contains changes which is not of type hint. It was added to prevent the variable type from becoming `Unbound`, but it affects when adding encoder...

When I changed the value of `c` to 61, I was able to read it with QRQR. (I'll make a PR after I check some cases.) https://github.com/OUDON/rmqrcode-python/blob/9dbbc2c6163fde897431a57cad9e475bf1e56e48/src/rmqrcode/format/rmqr_versions.py#L994-L1000

The cause does not appear to be that GeneratorPolynomials lacks an entry for '21'; rather, it seems to be due to a mistake in the constants. The code, updated to...

When I changed the value of `k` to 12, I was able to read it with QRQR. (I'll make a PR after I check some cases.) ![foo_R13x27](https://github.com/user-attachments/assets/b426c36f-312a-44a5-922e-5455825280dd) https://github.com/OUDON/rmqrcode-python/blob/9dbbc2c6163fde897431a57cad9e475bf1e56e48/src/rmqrcode/format/rmqr_versions.py#L576-L582

I haven't been able to fix this problem yet, but I've found that the code that QRQR can't recognize has 2 block definitions. ```python from src.rmqrcode import rMQR, ErrorCorrectionLevel from...

https://github.com/OUDON/rmqrcode-python/blob/9dbbc2c6163fde897431a57cad9e475bf1e56e48/src/rmqrcode/rmqrcode.py#L387-L409 line 394,406 : Change `break` into `continue` (I'll make a PR after I check some cases.)

The Alphanumeric mode cannot encode the newline character (`\n`). Therefore, the method `AlphanumericEncoder.is_valid_characters('\n')` is expected to return `False`. However, it currently returns `True`. The same issue occurs with the `NumericEncoder`....

This issue was fixed in a pull request #59. ```bash rmqr "FOO BAR" ./mytest.png ``` ![Image](https://github.com/user-attachments/assets/36cc52c0-9da1-47f0-984d-eaaa421000c7)