TJ Hoplock comments

Results 28 comments of


                                            TJ Hoplock

Add support `/sys/devices/system/node/nodeN/meminfo`

I stumbled across this PR while investigating for #565. If the approach used in #569 is accepted, it would seem like a similar approach may be needed here as well

feat: support to get rotational of the disk.

For what it's worth, there is already code in place to get rotational info as reported by udev: https://github.com/prometheus/node_exporter/blob/94ef5cc666ce6c797e1e7fbe9082cb1dc42af1f4/collector/diskstats_linux.go#L252-L258 However, I don't have that metric available on any of the...

feat: support to get rotational of the disk.

Turns out it already does exist in procfs and I forgot about it! https://pkg.go.dev/github.com/prometheus/[email protected]/blockdevice#BlockQueueStats Seems we would just need to utilize it

Feat: consider adopting procfs lib FS.Meminfo() for memory collector

Thanks @rexagod! I was mostly waiting on the green light to proceed, I'm still willing to take this on. However, I would be very happy/grateful if you would be willing...

Feat: consider adopting procfs lib FS.Meminfo() for memory collector

@SuperQ I've grown to agree with you since my last comment, re: explicit struct mapping and have [taken that approach in the PR](https://github.com/prometheus/node_exporter/pull/3043/files#diff-86c8e834b6a350446e4775a15ad2e45da0c5135cc13ab8e2908746a6039f40ebR29-R75). I'm happy to re-scope #3043 to just...

Feat: consider adopting procfs lib FS.Meminfo() for memory collector

Circling back to this -- the node exporter has been updated to use procfs lib for the meminfo collector, so I believe the core of this issue is complete. Are...

ref!: convert linux meminfo implementation to use procfs lib

Looking at the failing tests

ref!: convert linux meminfo implementation to use procfs lib

@SuperQ would you mind taking a look when you get time? Lemme know your thoughts :+1:

ref!: convert linux meminfo implementation to use procfs lib

Ah, good point, I appreciate the forethought. I'll rework it to not coerce nils and leave them out :+1:

ref!: convert linux meminfo implementation to use procfs lib

@SuperQ is this more in line with what you were thinking?