Abhishek Tiwari

Results 12 comments of Abhishek Tiwari

Working on: - [x] Double check that extension aligns with latest template. - [x] Update the properties syntax based on recent changes to the design of compile-time properties.

@gmlueck , @GarveyJoe Please do another round of review. I have addressed your comments and added FPGA properties as a separate extension.

There are currently common properties defined in both `annotated_ptr` and `annotated_arg`, this will need to be cleaned up and consolidated.

> There are currently common properties defined in both `annotated_ptr` and `annotated_arg`, this will need to be cleaned up and consolidated. I have cleaned this up. I think we should...

Hi @steffenlarsen all major comments have been addressed, please review this for merging. Addressing one minor review comment is remaining - I will address it today.

> @tiwaria1 - Could you please address @jessicadavies-intel's last comment, then I'm happy with this. I added a note in the property description.

> Please start with a commented compelling code sample before diving into the details of the API. Yup I have a unaddressed comment I filed on that. I will add...

ping @steffenlarsen , please take another look. Thank you! :)

@intel/dpcpp-specification-reviewers please review this spec. Thank you! :)

Hello, @intel/dpcpp-specification-reviewers apologies for the repeated pings. Please review this extension. Thank you! :)