Tina Boyce comments

Results 27 comments of


                                            Tina Boyce

Use Idp Account Name as key for credentials store

Hi @sledigabel, apologies for the delay in getting back to you. I had a discussion with @mapkon and we agreed to get this pull request going. There is currently a...

saml2aws: command not found

Closing this issue as a recently merged PR has an update README to cover Ubuntu-specific instructions #1238 . Thank you everyone who has contributed to this discussion.

Add the option to set a persistent storage for the browser provider

@fernbach it cannot be merged because there is a branch conflict and missing test coverage. If both conditions are met, then we will be more than happy to merge it.

Allow password to be saved to keychain with skip-prompt

@mapkon I have added tests which has resulted in a positive coverage https://app.codecov.io/gh/Versent/saml2aws/pull/547 . Is this enough for the PR to proceed?

Allow password to be saved to keychain with skip-prompt

FYI, updated the test to utilise defer as I forgot it was a thing.

helper/linuxkeyring: use configured pass directory

hi @eonpatapon , is this PR still relevant? I've noticed the issue this PR meant to close on merge is already closed.

helper/linuxkeyring: use configured pass directory

Ah okay, thanks for checking up on it for me. I'll keep this issue open.

Trivy vulnerability scanner finds outdated library in saml2aws v.2.30.0

Closing this issue as the current go.mod is using v1.17.0 https://github.com/Versent/saml2aws/blob/f183682460a430642782e958feb8473941a07fbe/go.mod#L25

Browser provider saml endpoint for AWS China is not correct

Thanks for giving us an update @donnyv12 , much appreciated. Was there any resolution to your issue @kun-shi ?

Login not possible in AzureAD when System-preferred multifactor authentication is activated

Thanks for your input on this @kieran-lowe . @BamOidaFixMan , is this still an issue?