Timothy Wu

Results 53 comments of Timothy Wu

Implement parachain inherents

> > @timwu20 When you try to scale encode a struct, its private (not exported) field can be read by our scale package. I observed this with InherentsData struct which...

Fix flaky tests

@danforbes can we change this to an epic and we will will create issues for the checkboxes in the description.

CRIT epoch not found in memory map

This may be related to #2627

pkg/scale: define sentinel errors and add error wrapping

@qdm12 where in the gossamer codebase do we actually check error types?

Migrate dot/network tests to integration tests

@timwu20 add some description

fix(lib/grandpa): avoid spamming round messages

@EclesioMeloJunior can you ensure the tests work? I'd rather not review multiple times if there are more changes required to fix the tests.

dot/state: fix `Rewind` by adding lookup for finalized block -> (round, setID) where block was finalized

@kishansagathiya are you working on this?

fix(cmd): `build-spec` can build a raw spec from a human readable spec

Can you mark it as draft for now @EclesioMeloJunior

dot/network: refactor `createNotificationsMessageHandle` into smaller functions

> It would be nice to break up createNotificationsMessageHandler into two smaller functions for handshake and notification message After looking at the codeI agree I think we should break up...

fix(trie): use direct Merkle value for database keys

Just looked at this. Great work!