Tim Ward

Results 6 comments of Tim Ward

I believe this is because the way selection is implemented (which is called by `selects?`): `def selection(field_name, selected_type: @selected_type, arguments: nil)` selected_type is used to find the corresponding field selections....

@jcchavezs You were involved with a discussions from the issue. If you have some time can you help me with this review?

> This potentially also enables caching of a normalized query which means the merging of overlapping fields could be cached. One aspect to consider is that a NQ is currently...

> I am ovarall happy with this PR except for naming. We need to get the naming right now I applied one of the suggested names. Let me know if...

@bbakerman, @andimarek: I have updated the PR to make the new instrumentation specific, as well as annotating it with `@ExperimentalApi` now to avoid consumers taking a hard dependency on it.

> @timward60 just to make you aware: we are adding a profiler: #3976 This will be merged very soon. Maybe if the only goal of the instrumentation is to measure...