Tim Vermeulen
Tim Vermeulen
> That seems…needlessly pedantic to the point of causing confusion to readers. > > The caller is working with an index, and wants to know “Is this index in a...
> * Should `replaceMin` and `replaceMax` to be added as part of this initial chunk of work? (Again, I think I'd prefer that those be follow-up PRs.) @AquaGeek For what...
> I think it's more natural to not pluralize of `start` and `end`, i.e. just have `endOfCommonPrefix`, `startOfCommonSuffix` Fair point. I think I went with this because we already have...
`slidingWindows` is on `Collection`, so it doesn't completely cover this, but something like `.adjacentPairs().map(...)` seems like it might.
>Where is "adjacentPairs" defined at? It doesn't currently exist, but if it did, it would (seemingly?) cover the functionality of this PR. But I'm not familiar with the corresponding C++...
Thanks for your contribution, @toddthomas! This is an interesting algorithm with a very clear real-world use case. 👍 It's also quite a specific use case, though. I think it shows...
I haven't given these APIs much thought yet, but here's my first impression. It's not immediately obvious to me why all these methods need to take a predicate if `.lazy.filter...
>It's also worth considering whether the performance gained is a constant factor (as here) or, say, takes something from O(_n_^2) to O(_n_). Only if you compare it to the `prefix`...
@swift-ci please test
I tried for a bit to make `EvenChunks.SubSequence` equal to `EvenChunks`, but it doesn't really seem to be possible (with how `EvenChunks.Index` currently works)! It is important that `Index` only...