Tim Froehlich

Results 55 comments of Tim Froehlich

I just fought with this problem, it's frustrating to know that this is a known issue. Confirmed on v1.5.8 (Rpi3, Yocto Warrior)

Are there any plans for support here?

Random suggestion (I saw your review request): Check out the [new Gradle lifecycle callbacks](https://docs.gradle.org/release-nightly/release-notes.html#build-authoring-improvements) in Gradle 8.8 (which is still in development but had an RC a few weeks ago)....

> I'm leaning into the CompositionLocal method. It lines up with how Material already works which is a big plus. I think the downside of it is that it makes...

> > @timothyfroehlich any idea why roborazzi test is showing this diff? > > It seems only the tests from the same design file have the diffs? I'm really not...

I've finished my review. It mostly looks good, but I think deduplicating the code will make implementation of String and Boolean variables much easier, and will help prevent bugs that...

Also, a thought, it might be helpful to use the name "DesignVariable" (or similar) instead of "Variable", to help with discussion of the code and with documentation in general.

The Validation test passes and there's no changes in screenshots, if that's what you mean. On Mon, May 20, 2024 at 7:41 PM Ralph Thomas ***@***.***> wrote: > Does the...

@rylin8 I've not tried to measure performance of this change. If @iamralpht wants me to then I absolutely can, it'll just take more time. Do you have any benchmarking tests...

Yep, known issue. Can look at implementing what [NowInAndroid](https://github.com/android/nowinandroid/blob/7f2ce57c67c68aa921de9231525a4a47ef431fe8/.github/workflows/Build.yaml#L89) did to recapture them.